*************************************************************************** ****************** TSCHK TOUCHSTONE PARSER BUG REPORT FORM **************** *************************************************************************** INSTRUCTIONS To report a bug in the TSCHK Touchstone Parser. Please fill out the top part of the following form and send the complete form to info@ibis.org. A list of reported bugs is maintained at http://ibis.org/bugs/tschk. *************************************************************************** PARSER VERSION NUMBER: 2.0.0 PLATFORM (SPARC, HP700, PC, etc.): PC OS AND VERSION: Windows 10 REPORTED BY: Michael Schaeder, Zuken DATE: June 20, 2022 DESCRIPTION OF BUG: Parser code improvement to improve file reading time. During test/eval we found that the performance can be improved easily by a factor of nearly 2. In our biggest test case we reduced reading time from 180 s to 100 s (55 %). This is achieved by allocating the data vectors not value by value but in a block. The block size can be determined/well estimated easily. The changes are (I think) clear and limited. From Mike LaBonte" "The description of the change in Mic’s original email is concise. Another way of expressing it would be to say that rather than allocating data vectors inside data reading loops, they are allocated once outside the loops and reused within the loops. The file and variable names could be given; there are at least a half dozen." Added note from Michael Schaedeer: "I quickly created a PPTX with the file-comparisons. Note: If changes are close to each other, only the upper change is in direct comparison. This is only the case with parser.cc on pages 5/10, 6/10, and 9/10. I hope this is of help." Actual code changes are documented in a presentation bug5.pptx that shows with 13 slides the original and modifed files. This presentation is saved on the under https://www.ibis.org/bugs/tschk/bug5/bug5.pptx Please note that the changes are fully QC'ed (following our standards). Please feel free to pick them up and make use of it as you like. CODE CHANGES: Four revised files are stored in https://www.ibis.org/bugs/tschk/bug5//bug5.zip. INSERT TOUCHSTONE FILE DEMONSTRATING THE BUG: None, validate with existing regression tests. ********************************************* ******************** BELOW FOR ADMINISTRATION AND TRACKING *************** ************************************************************************** BUG NUMBER: 5 SEVERITY: [FATAL, SEVERE, MODERATE, ANNOYING, ENHANCEMENT] ENHANCEMENT PRIORITY: [HIGH, MEDIUM, LOW] LOW STATUS: [OPEN, CLOSED, WILL NOT FIX, NOT A BUG] CLOSED FIXED VERSION: 2.1.0 FIXED DATE: April 19, 2024 NOTES ON BUG FIX: Classified at the June 24 2022 IBIS Open Forum. To be fixed in a later release ************************************************************************* *************************************************************************